Skip to content

Extends 'spe container permission list' command. Closes #6726#7053

Merged
MartinM85 merged 3 commits into
pnp:mainfrom
Adam-it:extends-container-permission-list-command
Jun 7, 2026
Merged

Extends 'spe container permission list' command. Closes #6726#7053
MartinM85 merged 3 commits into
pnp:mainfrom
Adam-it:extends-container-permission-list-command

Conversation

@Adam-it

@Adam-it Adam-it commented Nov 29, 2025

Copy link
Copy Markdown
Member

Closes #6726

Additionally, it performs a fixup in the container get command, in which we forgot to add the new options to the doc

@MartinM85 MartinM85 self-assigned this Dec 17, 2025

@MartinM85 MartinM85 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to allow users to retrieve permissions list by container name the user must provide also container type id.

Comment thread src/utils/spe.ts Outdated
@MartinM85 MartinM85 marked this pull request as draft January 1, 2026 13:50
@waldekmastykarz

Copy link
Copy Markdown
Member

@Adam-it could you please have a look?

@Adam-it

Adam-it commented May 28, 2026

Copy link
Copy Markdown
Member Author

@Adam-it could you please have a look?

Yep, fixed a similar PR and already got approved there so this one will follow. Will try this weekend
Thanks for the reminder

@Adam-it Adam-it force-pushed the extends-container-permission-list-command branch 3 times, most recently from c4888f7 to 501b054 Compare June 3, 2026 21:40
@Adam-it Adam-it force-pushed the extends-container-permission-list-command branch from 501b054 to ce80a68 Compare June 3, 2026 21:48
@Adam-it Adam-it marked this pull request as ready for review June 3, 2026 22:18
@Adam-it

Adam-it commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

@MartinM85 ready for another round

@MartinM85 MartinM85 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Adam-it. I have only small suggestions regarding the doc.

Comment thread docs/docs/cmd/spe/container/container-get.mdx Outdated
Comment thread docs/docs/cmd/spe/container/container-permission-list.mdx Outdated
@MartinM85 MartinM85 marked this pull request as draft June 4, 2026 09:38
Co-authored-by: Martin Machacek <machacek@edhouse.cz>
@Adam-it Adam-it marked this pull request as ready for review June 4, 2026 22:13
@Adam-it

Adam-it commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

Looks great @Adam-it. I have only small suggestions regarding the doc.

ready when you are

@MartinM85 MartinM85 merged commit d13bcb6 into pnp:main Jun 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a containerName option to spe container permission list command

3 participants